Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v11] Bump go.opentelemetry.io/contrib and go.opentelemetry.io/otel deps #23795

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

rosstimothy
Copy link
Contributor

@rosstimothy rosstimothy commented Mar 29, 2023

Fixes #23740 for branch/v11. Note: This is not a backport.

These pull in other updates indirectly, most notably is
cloud.google.com/go/firestore v1.9.0 which introduces deprecation
warnings about APIs that are still in use on this branch. In order
to prevent builds from failing the linter warnings about using a
deprecated function have been ignored. In addition several types are
now being pulled from cloud.google.com/go/firestore/apiv1/admin/adminpb
as it has replaced google.golang.org/genproto/googleapis/firestore/admin/v1.

@rosstimothy rosstimothy changed the title Bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp from v0.36.1 to v0.37.0 [v11] Bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp from v0.36.1 to v0.37.0 Mar 29, 2023
@rosstimothy rosstimothy marked this pull request as ready for review March 29, 2023 17:41
Copy link
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention the Firestore bump in the title, but as long as it works no objections on my part.

@rosstimothy
Copy link
Contributor Author

Please mention the Firestore bump in the title, but as long as it works no objections on my part.

I wanted to make sure that I satisfied the linter in CI first as sometimes there are differences between locally and CI before editing the PR and bugging for another review.

@rosstimothy rosstimothy changed the title [v11] Bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp from v0.36.1 to v0.37.0 [v11] Bump go.opentelemetry.io/contrib and go.opentelemetry.io/otel deps Apr 4, 2023
These pull in other updates indirectly, most notably is
`cloud.google.com/go/firestore v1.9.0` which introduces deprecation
warnings about APIs that are still in use on this branch. In order
to prevent builds from failing the linter warnings about using a
deprecated function have been ignored. In addition several types are
now being pulled from `cloud.google.com/go/firestore/apiv1/admin/adminpb`
as it has replaced `google.golang.org/genproto/googleapis/firestore/admin/v1`.
@rosstimothy rosstimothy added this pull request to the merge queue Apr 5, 2023
Merged via the queue into branch/v11 with commit ce6356f Apr 5, 2023
@rosstimothy rosstimothy deleted the tross/otel-update/v11 branch April 5, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants