Remove unused FIPS build targets and Dockerfiles #26859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakule
approved these changes
May 24, 2023
mdwn
approved these changes
May 24, 2023
wadells
force-pushed
the
walt/remove-fips-ubuntu-buildbox
branch
from
acbe5df
to
1488c7b
Compare
tcsc
approved these changes
May 30, 2023
FIPS is only built on amd64, and only on our centos:7 buildboxes. These other dockerfiles and targets are vestigial. Furthermore, the buildbox is a security risk, as ubuntu:18.04 is not supported after 2023-05-31. If/when we want to support FIPS on ARM, we can build off the centos:7 infrastructure, or its successor.
wadells
force-pushed
the
walt/remove-fips-ubuntu-buildbox
branch
from
1488c7b
to
3326606
Compare
|
After 8 different test builds https://drone.platform.teleport.sh/gravitational/teleport/25227/25/1 is clean enough. |
public-teleport-github-review-bot
bot
removed request for
r0mant,
jimbishopp and
fheinecke
wadells
added a commit
that referenced
this pull request
Jun 15, 2023
We do not use this buildbox for anything. This step is failing because the supporting infrastructure for buildbox-fips was removed in #26859.
wadells
added a commit
that referenced
this pull request
Jun 15, 2023
We do not use this buildbox for anything. This step is failing because the supporting infrastructure for buildbox-fips was removed in #26859.
wadells
added a commit
that referenced
this pull request
Jun 15, 2023
BUILDBOX_FIPS was removed, replaced by BUILDBOX_CENTOS7_FIPS. Unfortunately I missed updating this target in #26859. This subsequently broke e CI.
wadells
added a commit
that referenced
this pull request
Jun 20, 2023
* Remove Dockerfile-arm-fips We don't build fips for arm, as documented in #10581. * Stop building buildbox-fips We do not use this buildbox for anything. This step is failing because the supporting infrastructure for buildbox-fips was removed in #26859. * Fix fips buildbox BUILDBOX_FIPS was removed, replaced by BUILDBOX_CENTOS7_FIPS. Unfortunately I missed updating this target in #26859. This subsequently broke e CI.
gzdunek
pushed a commit
that referenced
this pull request
Sep 21, 2023
FIPS is only built on amd64, and only on our centos:7 buildboxes. These other dockerfiles and targets are vestigial. Furthermore, the buildbox is a security risk, as ubuntu:18.04 is not supported after 2023-05-31. If/when we want to support FIPS on ARM, we can build off the centos:7 infrastructure, or its successor. (cherry picked from commit fafa16a)
gzdunek
pushed a commit
that referenced
this pull request
Sep 21, 2023
* Remove Dockerfile-arm-fips We don't build fips for arm, as documented in #10581. * Stop building buildbox-fips We do not use this buildbox for anything. This step is failing because the supporting infrastructure for buildbox-fips was removed in #26859. * Fix fips buildbox BUILDBOX_FIPS was removed, replaced by BUILDBOX_CENTOS7_FIPS. Unfortunately I missed updating this target in #26859. This subsequently broke e CI. (cherry picked from commit 6ef1186)
gzdunek
pushed a commit
that referenced
this pull request
Sep 21, 2023
FIPS is only built on amd64, and only on our centos:7 buildboxes. These other dockerfiles and targets are vestigial. Furthermore, the buildbox is a security risk, as ubuntu:18.04 is not supported after 2023-05-31. If/when we want to support FIPS on ARM, we can build off the centos:7 infrastructure, or its successor. (cherry picked from commit fafa16a)
gzdunek
pushed a commit
that referenced
this pull request
Sep 21, 2023
* Remove Dockerfile-arm-fips We don't build fips for arm, as documented in #10581. * Stop building buildbox-fips We do not use this buildbox for anything. This step is failing because the supporting infrastructure for buildbox-fips was removed in #26859. * Fix fips buildbox BUILDBOX_FIPS was removed, replaced by BUILDBOX_CENTOS7_FIPS. Unfortunately I missed updating this target in #26859. This subsequently broke e CI. (cherry picked from commit 6ef1186)
gzdunek
pushed a commit
that referenced
this pull request
Sep 26, 2023
FIPS is only built on amd64, and only on our centos:7 buildboxes. These other dockerfiles and targets are vestigial. Furthermore, the buildbox is a security risk, as ubuntu:18.04 is not supported after 2023-05-31. If/when we want to support FIPS on ARM, we can build off the centos:7 infrastructure, or its successor. (cherry picked from commit fafa16a)
gzdunek
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Remove Dockerfile-arm-fips We don't build fips for arm, as documented in #10581. * Stop building buildbox-fips We do not use this buildbox for anything. This step is failing because the supporting infrastructure for buildbox-fips was removed in #26859. * Fix fips buildbox BUILDBOX_FIPS was removed, replaced by BUILDBOX_CENTOS7_FIPS. Unfortunately I missed updating this target in #26859. This subsequently broke e CI. (cherry picked from commit 6ef1186)
gzdunek
pushed a commit
that referenced
this pull request
Sep 26, 2023
FIPS is only built on amd64, and only on our centos:7 buildboxes. These other dockerfiles and targets are vestigial. Furthermore, the buildbox is a security risk, as ubuntu:18.04 is not supported after 2023-05-31. If/when we want to support FIPS on ARM, we can build off the centos:7 infrastructure, or its successor. (cherry picked from commit fafa16a)
gzdunek
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Remove Dockerfile-arm-fips We don't build fips for arm, as documented in #10581. * Stop building buildbox-fips We do not use this buildbox for anything. This step is failing because the supporting infrastructure for buildbox-fips was removed in #26859. * Fix fips buildbox BUILDBOX_FIPS was removed, replaced by BUILDBOX_CENTOS7_FIPS. Unfortunately I missed updating this target in #26859. This subsequently broke e CI. (cherry picked from commit 6ef1186)
This was referenced Sep 26, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Remove unused FIPS build boxes (#26859) FIPS is only built on amd64, and only on our centos:7 buildboxes. These other dockerfiles and targets are vestigial. Furthermore, the buildbox is a security risk, as ubuntu:18.04 is not supported after 2023-05-31. If/when we want to support FIPS on ARM, we can build off the centos:7 infrastructure, or its successor. (cherry picked from commit fafa16a) * Remove further unused fips infrastructure (#27900) * Remove Dockerfile-arm-fips We don't build fips for arm, as documented in #10581. * Stop building buildbox-fips We do not use this buildbox for anything. This step is failing because the supporting infrastructure for buildbox-fips was removed in #26859. * Fix fips buildbox BUILDBOX_FIPS was removed, replaced by BUILDBOX_CENTOS7_FIPS. Unfortunately I missed updating this target in #26859. This subsequently broke e CI. (cherry picked from commit 6ef1186) * Update signature --------- Co-authored-by: Walt <walt@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Remove unused FIPS build boxes (#26859) FIPS is only built on amd64, and only on our centos:7 buildboxes. These other dockerfiles and targets are vestigial. Furthermore, the buildbox is a security risk, as ubuntu:18.04 is not supported after 2023-05-31. If/when we want to support FIPS on ARM, we can build off the centos:7 infrastructure, or its successor. (cherry picked from commit fafa16a) * Remove further unused fips infrastructure (#27900) * Remove Dockerfile-arm-fips We don't build fips for arm, as documented in #10581. * Stop building buildbox-fips We do not use this buildbox for anything. This step is failing because the supporting infrastructure for buildbox-fips was removed in #26859. * Fix fips buildbox BUILDBOX_FIPS was removed, replaced by BUILDBOX_CENTOS7_FIPS. Unfortunately I missed updating this target in #26859. This subsequently broke e CI. (cherry picked from commit 6ef1186) * Update signature --------- Co-authored-by: Walt <walt@goteleport.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIPS is only built on amd64 (no ARM per #10581), and only on our
centos:7buildboxes. These other Dockerfiles and targets are vestigial. Furthermore, the buildbox is a security risk, as ubuntu:18.04 is not supported after 2023-05-31.If/when we want to support FIPS on ARM, we can build off the
centos:7infrastructure, or its successor.Contributes to #26856
Testing Done
Underway -- I'm running a full dev build.
Build: https://drone.platform.teleport.sh/gravitational/teleport/25227
Promote: Forthcoming