Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v13] AWS OIDC - List EC2: add AWS EC2 Instance ID as label #31436

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[v13] AWS OIDC - List EC2: add AWS EC2 Instance ID as label #31436

merged 1 commit into from
Sep 5, 2023

Commits on Sep 5, 2023

  1. AWS OIDC - List EC2: add instance id as label 

    When listing EC2 instances we should be able to tell which ones were
already added.
To do so, we should use the instance-id which is unique.
We can't use the Spec.CloudMetadata.AWS.InstanceID because predicate
can't use fields that are optional.

This PR adds the InstanceID as label.
It uses `teleport.dev/instance-id` label key.

When creating a Node from WebUI, it will send the same set of labels
that was received.
So, WebUI will send this same label.

When listing EC2 instances, WebUI queries the backend for a list of
Nodes of type EC2 EICE and the same `instance-id` and uses the result to
show which ones were already added.
    @marcoandredinis
    marcoandredinis authored and github-actions committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    ba38c2e View commit details
    Browse the repository at this point in the history