Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add web support #476

Merged
merged 17 commits into from
Jun 19, 2023
Merged

Feature: Add web support #476

merged 17 commits into from
Jun 19, 2023

Conversation

chrispader
Copy link
Contributor

@chrispader chrispader commented Jun 6, 2023

Fixes #224

Continuing the work of @NiciusB

This includes implementation of captureRef on web and an updated example with web support

@chrispader chrispader marked this pull request as ready for review June 7, 2023 09:45
@chrispader
Copy link
Contributor Author

I updated the example and all of the relevant code sections, that were left off.

This PR should be ready for review! 🚀 @gre

The functionality is limited to captureRef for now, as in @NiciusB's implementation

@chrispader chrispader changed the title Fetaure: Add web support Feature: Add web support Jun 8, 2023
@chrispader
Copy link
Contributor Author

chrispader commented Jun 19, 2023

Hi @gre, did you find any time to have a look at this PR yet? :)

We plan on using this library on web for a couple of features in a pretty big production app called "Expensify" and we want to prevent creating a fork or patching this library.

Lmk if i can be of help somehow! ☺️

@gre gre self-requested a review June 19, 2023 10:36
@gre gre merged commit bdf3eef into gre:master Jun 19, 2023
@gre
Copy link
Owner

gre commented Jun 19, 2023

awesome work, thanks a lot 👍

@chrispader
Copy link
Contributor Author

Oh thanks, that was quick haha! 🚀🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature-request] Support web
3 participants