Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] add create_temp_table flag to ExecutionEngineConfigSchema #6331

Conversation

tommy-watts-depop
Copy link
Contributor

@tommy-watts-depop tommy-watts-depop commented Nov 9, 2022

create_temp_table flag for SQLAlchemyExecutionEngine is not in ExecutionEngineConfigSchema

fixes #6332

Changes proposed in this pull request:

  • add create_temp_table Boolean field to ExecutionEngineConfigSchema

After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anthonyburdi anthonyburdi enabled auto-merge (squash) November 9, 2022 15:21
@netlify
Copy link

netlify bot commented Nov 9, 2022

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit ad3b8e1
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/636bcccfff24ed0008fad8e7
😎 Deploy Preview https://deploy-preview-6331--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@anthonyburdi anthonyburdi enabled auto-merge (squash) November 9, 2022 15:53
@anthonyburdi anthonyburdi merged commit 5e97bf2 into great-expectations:develop Nov 9, 2022
Shinnnyshinshin pushed a commit that referenced this pull request Nov 10, 2022
* develop:
  [MAINTENANCE] Change the number of expected Expectations in the 'quick check' stage of build_gallery pipeline (#6333)
  [BUGFIX] add create_temp_table flag to ExecutionEngineConfigSchema (#6331)
  [DOCS] Add ZenML into integration table in Readme (#6144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_temp_table flag for SQLAlchemyExecutionEngine is not in ExecutionEngineConfigSchema
3 participants