[MAINTENANCE] In ExecutionEngine: Make variable names and usage more descriptive of their purpose. #6342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👇 Click on the image for a new way to code review
Legend |
billdirks
approved these changes
Nov 10, 2022
| @@ -993,8 +993,8 @@ def resolve_metric_bundle( | |||
|
|
|||
| for query in queries.values(): | |||
| domain_kwargs: dict = query["domain_kwargs"] | |||
| selectable: Any = self.get_domain_records( | |||
| domain_kwargs=domain_kwargs, | |||
| selectable: Selectable = self.get_domain_records( | |||
There was a problem hiding this comment.
Thanks for cleaning up this Any!
alexsherstinsky
deleted the
maintenance/GREAT-1103/GREAT-1364/alexsherstinsky/execution_engine/make_variable_names_and_usage_more_descriptive-2022_11_10-257
branch
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Nov 11, 2022
…r-usage-stats-opt * develop: [MAINTENANCE] In ExecutionEngine: Make variable names and usage more descriptive of their purpose. (#6342) [MAINTENANCE] Refactor variable aggregation/substitution logic into `ConfigurationProvider` hierarchy (#6321) [MAINTENANCE] Add missing one-line docstrings and try to make the others consistent (#6340) [BUGFIX] Fix issue with misaligned indentation in docs snippets (#6339)
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Nov 11, 2022
…nn/great_expectations into feature/sql_unexpected_index_list * 'feature/sql_unexpected_index_list' of github.com:abekfenn/great_expectations: [MAINTENANCE] In ExecutionEngine: Make variable names and usage more descriptive of their purpose. (#6342) [MAINTENANCE] Refactor variable aggregation/substitution logic into `ConfigurationProvider` hierarchy (#6321) [MAINTENANCE] Add missing one-line docstrings and try to make the others consistent (#6340) [BUGFIX] Fix issue with misaligned indentation in docs snippets (#6339)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123).Previous Design Review notes:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!