Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dependency warning from @svgr/core #785

Closed
joshkel opened this issue Oct 5, 2022 · 0 comments Β· Fixed by #786 Β· 4 remaining pull requests
Closed

Peer dependency warning from @svgr/core #785

joshkel opened this issue Oct 5, 2022 · 0 comments Β· Fixed by #786 Β· 4 remaining pull requests

Comments

@joshkel
Copy link
Contributor

joshkel commented Oct 5, 2022

πŸ› Bug Report

Installing @svgr/core with Yarn Modern (Yarn 2+) gives the following warning:

➀ YN0002: β”‚ @svgr/core@npm:6.4.0 doesn't provide @babel/core (p0b84c), requested by @svgr/babel-preset

From what I understand, this may cause problems when using @svgr/core with Yarn Modern's PnP resolver.

I believe this was introduced by #781. It could be fixed by adding @babel/core as an additional dependency of @svgr/core.

To Reproduce

From a new directory:

➜  tmp ls
yarn init -2
yarn add @svgr/core

Expected behavior

No Yarn warnings.

Link to repl or repo (highly encouraged)

Not needed (it's easy to create locally, following the instructions above)

Run npx envinfo --system --binaries --npmPackages @svgr/core,@svgr/cli,@svgr/webpack,@svgr/rollup --markdown --clipboard

## System:
 - OS: macOS 12.6
 - CPU: (10) arm64 Apple M1 Pro
 - Memory: 74.59 MB / 16.00 GB
 - Shell: 5.8.1 - /bin/zsh
## Binaries:
 - Node: 16.15.1 - ~/.nvm/versions/node/v16.15.1/bin/node
 - Yarn: 1.22.19 - /opt/homebrew/bin/yarn
 - npm: 8.11.0 - ~/.nvm/versions/node/v16.15.1/bin/npm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment