Return :error as first element of tuple instead of :fail #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grempe
added a commit
that referenced
this pull request
Nov 10, 2015
Return :error as first element of tuple instead of :fail
|
Pushed in newly released version 1.0.0. Thanks for the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
ExRated.check_rate/3to return{:error, limit}when the rate limit is exceeded, rather than{:fail, limit}. Using:erroras the first key of a returned tuple seems to be a pretty standard Elixir pattern, and it will make it easier to integrate ex_rated with other libraries, like MonadEx.If you're using SemVer, this might require a major version bump (i.e. 1.0.0) since this change is not backwards compatible.