Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for persistence through DETS #8

Merged
merged 1 commit into from
Jan 18, 2016

Conversation

wstucco
Copy link
Contributor

@wstucco wstucco commented Jan 18, 2016

add persistence tests

when launched with persistent: true the ExRated server
will persist data on disk in a file with the same name
of ets_table_name.
When started with persistence activated, ExRated will reload
the data from the disk, store it in memory and continue from there.
When stopped (actually when terminate is executed), the data will
be persisted back on disk.

add persistence tests

when launched with persistent: true the ExRated server
will persist data on disk in a file with the same name
of ets_table_name.
When started with persistence activated, ExRated will reload
the data from the disk, store it in memory and continue from there.
When stopped (actually when terminate is executed), the data will
be persisted back on disk.
grempe added a commit that referenced this pull request Jan 18, 2016
Add support for persistence through DETS
@grempe grempe merged commit 6dd1201 into grempe:master Jan 18, 2016
@grempe
Copy link
Owner

grempe commented Jan 18, 2016

Merged and version 1.2.0 pushed to hex.pm. Thanks! I added some trivial docs too, please check that they are correct.

https://hex.pm/packages/ex_rated/1.2.0

@wstucco
Copy link
Contributor Author

wstucco commented Jan 18, 2016

great, thanks!
just a quick note on the docs: persistent must be true to activate the on disk serialization.
I also made the ets table public for testing purposes and forgot to change it back to private.
Could you fix it or do you want me to send a new PR?

thanks again, great module

@grempe
Copy link
Owner

grempe commented Jan 18, 2016

Would you mind new pull request for docs and fix? Thanks
On Mon, Jan 18, 2016 at 14:08 Massimo Ronca notifications@github.com
wrote:

great, thanks!

just a quick note on the docs: persistent must be true to activate the on
disk serialization.

I also made the ets table public for testing purposes and forgot to change
it back to private.

Could you fix it or do you want me to send a new PR?

thanks again, great module


Reply to this email directly or view it on GitHub
#8 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants