Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS: #723 #726 margin to replace verticalMargin #1308

Merged
merged 2 commits into from
Jul 27, 2020

Commits on Jul 7, 2020

  1. TS: gridstack#723 gridstack#726 margin to replace verticalMargin

    * complete re-write how we size/position items dealing with margin
    * we now have a single `margin` grid option which will set all 4 sides instead of one in code nad one in CSS
    * also have `marginTop/Bottom/Left/Right` if more precise setting is required
    * greatly reduced the layout code as margin are now inside the grid-item
    (affects content)
    * fixed code so `cellHeight: 'auto'` (now the default) will create real square cells
    (used to be off due to margin)
    * grid will now have consistant spacing (above/below first/last rows)
    adumesny committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    94e1341 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. TS: getCellFromPixel() fix and tests for gridstack#810 (roundoff error)

    * forgot to update the test case for gridstack#810 changes
    * also found getCellFromPixel() was incorrect in rounding as well or delaing with margins
    (which don't affect cell size, just content)
    adumesny committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    b79a603 View commit details
    Browse the repository at this point in the history