Fix/base install #1009
Merged
Fix/base install #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
force-pushed
the
fix/base-install
branch
6 times, most recently
from
3ad096c
to
2a9706c
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
collindutter
force-pushed
the
fix/base-install
branch
from
2a9706c
to
ba8cb12
Compare
collindutter
force-pushed
the
fix/base-install
branch
from
69f646a
to
9fc43f1
Compare
collindutter
force-pushed
the
fix/base-install
branch
from
9fc43f1
to
a338072
Compare
dylanholmes
approved these changes
Jul 23, 2024
| @staticmethod | ||
| def build_span_exporter(base_url: str, api_key: str, headers: dict, structure_run_id: str) -> SpanExporter: | ||
| @define | ||
| class SpanExporter(import_optional_dependency("opentelemetry.sdk.trace.export").SpanExporter): |
| - name: Init environment | ||
| uses: ./.github/actions/init-bare-environment | ||
| - name: Run unit tests | ||
| run: poetry run pytest -n auto tests/unit/structures |
There was a problem hiding this comment.
That's all the tests we can run? I suppose that is sufficient to cover the majority of missed optional imports, right?
There was a problem hiding this comment.
Yeah we really only need to run a single test to know whether it's broken or not. I arbitrarily picked these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
NA.