Removed the __all__
declaration from the griptape.mixins
module.
#1164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Griptape often uses
__all__
in its packages to simplify module imports for users. However, this convenience comes with a tradeoff: all modules within the package must be imported to be included in__all__
. While this is usually not an issue, it can lead to circular dependency problems in certain cases.The
griptape.mixins
package is particularly prone to these issues because its modules aren't restricted to specific parts of the framework. As a result, mixin modules can easily introduce circular dependencies. For instance, simply adding aJ2
import toRule
can trigger the following error:This PR addresses the issue by removing
__all__
fromgriptape.mixins
and updating all imports to reference the specific module directly. While this change is technically breaking, I haven't included a migration guide since most users are unlikely to use mixins directly.Issue ticket number and link
NA