Change StructureRunTask parent to PromptTask #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vachillo
reviewed
Oct 7, 2024
| @@ -23,7 +23,7 @@ def test_run_with_env(self, mock_config): | |||
| mock_config.drivers_config.prompt_driver = MockPromptDriver(mock_output=lambda _: os.environ["KEY"]) | |||
| agent = Agent() | |||
| driver = LocalStructureRunDriver(structure_factory_fn=lambda: agent, env={"KEY": "value"}) | |||
| task = StructureRunTask(driver=driver) | |||
| task = StructureRunTask(structure_run_driver=driver) | |||
There was a problem hiding this comment.
the field needs to be updated to structure_run_driver i think
There was a problem hiding this comment.
Oh shoot I meant to undo that particular change (will be done in a future PR).
collindutter
force-pushed
the
refactor/structure-run-task
branch
from
d50d9e9
to
bbbfbc8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
collindutter
force-pushed
the
refactor/structure-run-task
branch
from
bbbfbc8
to
0d41d99
Compare
vachillo
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removes
BaseMultiTextInputTaskasPromptTaskcan now accept multiple inputs.Issue ticket number and link
Road to 1.0