Add alias to GriptapeCloudConversationMemoryDriver
#1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
collindutter
reviewed
Oct 8, 2024
| @api_key.validator # pyright: ignore[reportAttributeAccessIssue] | ||
| def validate_api_key(self, _: Attribute, value: Optional[str]) -> str: | ||
| if value is None: | ||
| raise ValueError(f"{self.__class__.__name__} requires an API key") | ||
| return value | ||
|
|
||
| @property |
There was a problem hiding this comment.
Should we make this a @cached_property since it's so expensive?
There was a problem hiding this comment.
my concern was that the store method would invalidate the cached value, but i guess i can update the method to invalidate self._thread
There was a problem hiding this comment.
Yeah just call del self.thread to invalidate.
collindutter
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
adding parameter
aliastoGriptapeCloudConversationMemoryDriverso a thread can be fetched by the provided aliasIssue ticket number and link
📚 Documentation preview 📚: https://griptape--1237.org.readthedocs.build//1237/