Toolkit Task Improvements #1268
Open
+82
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
collindutter
force-pushed
the
fix/toolkit
branch
2 times, most recently
from
89c688c
to
c057ceb
Compare
collindutter
force-pushed
the
fix/toolkit
branch
from
c057ceb
to
bc6c893
Compare
collindutter
commented
Oct 17, 2024
Comment on lines
-183
to
-185
| elif not subtask.actions: | ||
| # handle case when the LLM failed to follow the ReAct prompt and didn't return a proper action | ||
| subtask.output = subtask.input |
There was a problem hiding this comment.
We need to handle this slightly differently depending on whether we're using native tool calling or not. Moved this logic to ActionsSubtask.
collindutter
commented
Oct 17, 2024
Comment on lines
-250
to
+273
| def __parse_actions(self, actions_matches: list[str]) -> None: | ||
| def __parse_actions(self, actions_matches: list[str]) -> list[ToolAction]: | ||
| if len(actions_matches) == 0: | ||
| return | ||
| return [] | ||
| try: | ||
| data = actions_matches[-1] | ||
| actions_list: list[dict] = json.loads(data, strict=False) | ||
|
|
||
| self.actions = [self.__process_action_object(action_object) for action_object in actions_list] | ||
| return [self.__process_action_object(action_object) for action_object in actions_list] | ||
| except json.JSONDecodeError as e: | ||
| logger.exception("Subtask %s\nInvalid actions JSON: %s", self.origin_task.id, e) | ||
|
|
||
| self.output = ErrorArtifact(f"Actions JSON decoding error: {e}", exception=e) | ||
|
|
||
| return [] | ||
|
|
There was a problem hiding this comment.
Fewer side effects, more consistent with native tool calling action parsing.
collindutter
commented
Oct 17, 2024
Comment on lines
-32
to
-34
| !!! warning | ||
| `JsonSchemaRule` may break [ToolkitTask](../structures/tasks.md#toolkit-task) which relies on a specific [output token](https://github.com/griptape-ai/griptape/blob/e6a04c7b88cf9fa5d6bcf4c833ffebfab89a3258/griptape/tasks/toolkit_task.py#L28). | ||
|
|
There was a problem hiding this comment.
Technically this is still true for non native tool calling, but that feels edge case enough where it's not worth mentioning.
collindutter
commented
Oct 17, 2024
Comment on lines
-19
to
-20
|
|
||
| Actions might store their output in memory as artifacts (with `memory_name` and `artifact_namespace`). If action output is stored in memory, ALWAYS try to pass it to another action. NEVER make up memory names or artifact namespaces. |
There was a problem hiding this comment.
This was causing the LLM to hallucinate these keys into the Tool schema. The Tool schema is descriptive enough, we don't need to mention them here.
collindutter
force-pushed
the
fix/toolkit
branch
from
bc6c893
to
d99b7cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changed
ToolkitTasksystem prompt to no longer mentionmemory_nameandartifact_namespace.ToolkitTaskwith native tool calling no longer need to provide their final answer asAnswer:.Fixed
memory_nameandartifact_namespaceinto Tool schemas when usingToolkitTask.ToolkitTask.Issue ticket number and link
https://discord.com/channels/1096466116672487547/1105169591619027055/1296270653238022226
📚 Documentation preview 📚: https://griptape--1268.org.readthedocs.build//1268/