Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/event listener drivers #735

Merged
merged 10 commits into from
Apr 10, 2024
Merged

Conversation

collindutter
Copy link
Member

No description provided.

@collindutter collindutter force-pushed the feature/event-listener-drivers branch 3 times, most recently from a3854c8 to 5bf764b Compare April 8, 2024 23:17
@collindutter collindutter marked this pull request as ready for review April 8, 2024 23:50
@collindutter collindutter marked this pull request as draft April 9, 2024 16:01
@collindutter collindutter marked this pull request as ready for review April 9, 2024 17:12
dylanholmes
dylanholmes previously approved these changes Apr 9, 2024
Copy link
Contributor

@dylanholmes dylanholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

def event_handler(event: BaseEvent):
self._event_queue.put(event)

stream_event_listener = EventListener(
event_handler, event_types=[CompletionChunkEvent, FinishPromptEvent, FinishStructureRunEvent]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I see why you overrode publish_event in LocalEventListenerDriver

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧵

Copy link
Member

@andrewfrench andrewfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool.

@collindutter collindutter merged commit c403954 into dev Apr 10, 2024
6 checks passed
@collindutter collindutter deleted the feature/event-listener-drivers branch April 10, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants