Remove boto3 from types #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vachillo
previously approved these changes
Apr 10, 2024
collindutter
force-pushed
the
fix/event-drivers-2
branch
from
57732a7
to
aa3d791
Compare
dylanholmes
previously approved these changes
Apr 11, 2024
griptape/schemas/base_schema.py
Outdated
|
|
||
| # These modules are required to avoid `NameError`s when resolving types. | ||
| from griptape.drivers import BaseConversationMemoryDriver, BasePromptDriver, BasePromptModelDriver | ||
| from griptape.structures import Structure | ||
| from griptape.utils import PromptStack | ||
| from griptape.tokenizers.base_tokenizer import BaseTokenizer | ||
| import boto3 | ||
|
|
||
| boto3 = import_optional_dependency("boto3") if is_dependency_installed("boto3") else {} |
There was a problem hiding this comment.
If this is ever needed in more than one place, then might be nice to have something like try_import_optional_dependency().
Btw, what happens if you default to None instead of {}?
There was a problem hiding this comment.
Honestly not totally sure, I think it was working fine with both. But I updated to a more appropriate value Any since that's an actual python type.
collindutter
force-pushed
the
fix/event-drivers-2
branch
from
6d38011
to
8a412d4
Compare
andrewfrench
approved these changes
Apr 11, 2024
collindutter
force-pushed
the
fix/event-drivers-2
branch
from
8a412d4
to
726f0f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes serialization crash when
boto3is not installed via extras.Side effect of this is that we cannot useboto3type hints (boto.Session) in any serializable fields.