Update OpenAI image query default model to GPT-4o #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vachillo
reviewed
May 23, 2024
| @@ -69,7 +69,7 @@ class AzureOpenAiStructureConfig(StructureConfig): | |||
| ) | |||
| image_query_driver: BaseImageQueryDriver = field( | |||
| default=Factory( | |||
| lambda self: AzureOpenAiVisionImageQueryDriver( | |||
| lambda self: AzureOpenAiImageQueryDriver( | |||
There was a problem hiding this comment.
can you update the model to gpt-4o here too since its available?
There was a problem hiding this comment.
as well as the prompt driver too
There was a problem hiding this comment.
do we need a similar Azure deployment note here for GPT-4o?
There was a problem hiding this comment.
nope, gpt-4o is its own model in the portal
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
vachillo
previously approved these changes
May 23, 2024
vachillo
reviewed
May 23, 2024
| from griptape.engines import ImageQueryEngine | ||
| from griptape.loaders import ImageLoader | ||
|
|
||
| driver = AzureOpenAiVisionImageQueryDriver( | ||
| driver = AzureOpenAiImageQueryDriver( |
There was a problem hiding this comment.
AZURE_OPENAI_ENDPOINT_3 and AZURE_OPENAI_API_KEY_3 can be changed to use _2, and the model and azure_deployment can be changed to gpt-4o. sorry should have clarified this.
vachillo
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs and configurations to use GPT-4o to power image queries. Rename OpenAI Image Query Drivers (and descendants) to not specify Vision in their names.
📚 Documentation preview 📚: https://griptape--802.org.readthedocs.build//802/