Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cohere prompt driver, add cohere embedding driver, cohere stru… #831

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Update cohere prompt driver, add cohere embedding driver, cohere stru… #831

merged 4 commits into from
Jun 5, 2024

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Jun 4, 2024 •
edited by github-actions bot
Loading

📚 Documentation preview 📚: https://griptape--831.org.readthedocs.build//831/

@collindutter collindutter requested a review from a team June 4, 2024 23:05
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.18519% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ptape/drivers/embedding/cohere_embedding_driver.py 80.00% 2 Missing and 2 partials ⚠️
griptape/drivers/prompt/cohere_prompt_driver.py 80.00% 1 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

dylanholmes
dylanholmes requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@dylanholmes dylanholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

Only one "real" comment about add the extra + updating docs.

docs/griptape-framework/drivers/embedding-drivers.md Outdated Show resolved Hide resolved
griptape/config/cohere_structure_config.py Outdated Show resolved Hide resolved
dylanholmes
dylanholmes previously approved these changes Jun 5, 2024
View reviewed changes
@collindutter collindutter merged commit 7a137e1 into dev Jun 5, 2024
11 checks passed
@collindutter collindutter deleted the feature/cohere branch June 5, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanholmes dylanholmes dylanholmes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@collindutter @dylanholmes