Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BedrockPromptDriver to use Converse API #834

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Update BedrockPromptDriver to use Converse API #834

merged 1 commit into from
Jun 5, 2024

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Jun 5, 2024 •
edited
Loading

  • BREAKING: Removed AmazonBedrockPromptDriver.prompt_model_driver as it is no longer needed with the AmazonBedrockPromptDriver Converse API implementation.
  • BREAKING: Removed BedrockClaudePromptModelDriver.
  • BREAKING: Removed BedrockJurassicPromptModelDriver.
  • BREAKING: Removed BedrockLlamaPromptModelDriver.
  • BREAKING: Removed BedrockTitanPromptModelDriver.
  • BREAKING: Removed BedrockClaudeTokenizer, use SimpleTokenizer instead.
  • BREAKING: Removed BedrockJurassicTokenizer, use SimpleTokenizer instead.
  • BREAKING: Removed BedrockLlamaTokenizer, use SimpleTokenizer instead.
  • BREAKING: Removed BedrockTitanTokenizer, use SimpleTokenizer instead.
  • Updated AmazonBedrockPromptDriver to use Converse API.

📚 Documentation preview 📚: https://griptape--834.org.readthedocs.build//834/

Closes #818, #312, #664

vasinov
vasinov previously approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@vasinov vasinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@collindutter collindutter requested a review from vasinov June 5, 2024 18:59
@codecov Codecov
Copy link

codecov bot commented Jun 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ape/drivers/prompt/amazon_bedrock_prompt_driver.py 80.76% 1 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

@collindutter collindutter merged commit e167885 into dev Jun 5, 2024
11 checks passed
@collindutter collindutter deleted the feature/bedrock-converse branch June 5, 2024 19:22
@collindutter collindutter linked an issue Jun 5, 2024 that may be closed by this pull request
Implement Bedrock's Converse API #818
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasinov vasinov vasinov approved these changes

@andrewfrench andrewfrench Awaiting requested review from andrewfrench

@dylanholmes dylanholmes Awaiting requested review from dylanholmes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Bedrock's Converse API
2 participants
@collindutter @vasinov