Improve error when knowledgebase is missing a description #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
vachillo
previously approved these changes
Jun 6, 2024
| @@ -52,4 +52,6 @@ def _get_knowledge_base_description(self) -> str: | |||
| if "description" in response: | |||
| return response["description"] | |||
| else: | |||
| raise ValueError(f'Error getting Knowledge Base description: {response["message"]}') | |||
| raise ValueError( | |||
| "No description found for Knowledge Base. Please set a description, or manually set the `GriptapeCloudKnowledgeBaseClient.description` attribute." | |||
There was a problem hiding this comment.
maybe throw the id in the message?
There was a problem hiding this comment.
Does that come back in the response?
There was a problem hiding this comment.
not sure, but cant you pull it from self. knowledge_base_id?
collindutter
force-pushed
the
fix/kb-error
branch
from
1cf93a5
to
106ce31
Compare
vachillo
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.