Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ollama #847

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Feature/ollama #847

merged 1 commit into from
Jun 18, 2024

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Jun 7, 2024


📚 Documentation preview 📚: https://griptape--847.org.readthedocs.build//847/

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
griptape/drivers/prompt/ollama_prompt_driver.py 96.66% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@collindutter collindutter force-pushed the feature/ollama branch 2 times, most recently from 39a3a2e to 7706bee Compare June 17, 2024 16:54
@collindutter collindutter marked this pull request as ready for review June 17, 2024 16:55
Copy link
Member

@andrewfrench andrewfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small docs issues, otherwise 🦙 ✅

Comment on lines 251 to 266
```python
import os

from griptape.config import StructureConfig
from griptape.drivers import OllamaPromptDriver
from griptape.tools import Calculator
from griptape.tokenizers import SimpleTokenizer
from griptape.structures import Agent


agent = Agent(
config=StructureConfig(
prompt_driver=OllamaPromptDriver(
model="llama3",
),
),
)
agent.run("What color is the sky at different times of the day?")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this code block is missing a closing markdown tag (```) and has a few extraneous imports.

@collindutter collindutter force-pushed the feature/ollama branch 2 times, most recently from c242e00 to d0284b8 Compare June 18, 2024 15:50
@collindutter collindutter force-pushed the feature/ollama branch 2 times, most recently from adff5ba to d0284b8 Compare June 18, 2024 17:21
@collindutter collindutter merged commit 3a203ed into dev Jun 18, 2024
11 checks passed
@collindutter collindutter deleted the feature/ollama branch June 18, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants