Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Qdrant VectorDB #928

Merged
merged 89 commits into from
Jul 2, 2024
Merged

Add support for Qdrant VectorDB #928

merged 89 commits into from
Jul 2, 2024

Conversation

vachillo
Copy link
Member

@vachillo vachillo commented Jul 2, 2024

closes #812

Describe your changes

these are the same changes from #812 (with a modified docs integration test example), but we need to run the integration tests on a non-forked branch to get access to the repository secrets. #929 to track.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added thorough tests.
  • Is this a notable change? If so, please update the changelog.

📚 Documentation preview 📚: https://griptape--928.org.readthedocs.build//928/

collindutter
collindutter previously approved these changes Jul 2, 2024
collindutter
collindutter previously approved these changes Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 87.93103% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ptape/drivers/vector/qdrant_vector_store_driver.py 87.71% 3 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

collindutter
collindutter previously approved these changes Jul 2, 2024
@vachillo vachillo changed the title Qdrant integ tests Add support for Qdrant VectorDB Jul 2, 2024
@vachillo vachillo merged commit 07e2a1c into dev Jul 2, 2024
11 of 12 checks passed
@vachillo vachillo deleted the qdrant_integ_tests branch July 2, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants