Add generic artifact #983
Merged
Add generic artifact #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Not tied to the name. Would |
dylanholmes
previously approved these changes
Jul 15, 2024
emjay07
reviewed
Jul 16, 2024
collindutter
force-pushed
the
feature/generic-artifact
branch
5 times, most recently
from
4cd3754
to
29e046a
Compare
emjay07
previously approved these changes
Jul 17, 2024
vasinov
previously approved these changes
Jul 17, 2024
collindutter
force-pushed
the
feature/generic-artifact
branch
from
29e046a
to
1f87ca0
Compare
collindutter
force-pushed
the
feature/generic-artifact
branch
from
4432fba
to
b0fc2e9
Compare
dylanholmes
previously approved these changes
Jul 17, 2024
|
|
||
| @define | ||
| class GenericArtifact(BaseArtifact): | ||
| value: Any = field(metadata={"serializable": True}) |
There was a problem hiding this comment.
What if its not serializable?
There was a problem hiding this comment.
I don't know off the top of my head but it'd be however Marshmallow handles it via field.Raw. We do need it serializable though, so I think I'd rather just deal with it when we come across a value that is non-intuitively serializable.
dylanholmes
approved these changes
Jul 18, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a
GenericArtifactthat can be used to pass arbitrary data around. Also adds an example of how we can use this Artifact to pass a Google-specific video file toGooglePromptDriver.Issue ticket number and link
NA