-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datadog observability driver #998
Changes from 15 commits
cd690fa
f240740
aab35a4
0316684
c8ad6c1
caf2b3c
530a47c
97b4fe6
871d716
971e6a0
0bd3001
f2b8fdb
e6cc5b0
e658a4e
d15822e
d171f2d
ab35705
3080e81
9260df8
2785f1f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import os | ||
|
||
from attrs import Factory, define, field | ||
from opentelemetry.exporter.otlp.proto.http.trace_exporter import OTLPSpanExporter | ||
from opentelemetry.sdk.trace import SpanProcessor | ||
from opentelemetry.sdk.trace.export import BatchSpanProcessor | ||
|
||
from griptape.drivers.observability.open_telemetry_observability_driver import OpenTelemetryObservabilityDriver | ||
|
||
|
||
@define | ||
class DatadogObservabilityDriver(OpenTelemetryObservabilityDriver): | ||
datadog_agent_endpoint: str = field( | ||
default=Factory(lambda: os.getenv("DD_AGENT_ENDPOINT", "http://localhost:4318")), kw_only=True | ||
) | ||
span_processor: SpanProcessor = field( | ||
default=Factory( | ||
lambda self: BatchSpanProcessor(OTLPSpanExporter(endpoint=self.datadog_agent_endpoint + "/v1/traces")), | ||
takes_self=True, | ||
), | ||
kw_only=True, | ||
) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,18 +18,28 @@ | |
|
||
@define | ||
class OpenTelemetryObservabilityDriver(BaseObservabilityDriver): | ||
service_name: str = field(kw_only=True) | ||
service_name: str = field(default="griptape", kw_only=True) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Small refactoring opportunity: If we have a default here, then we don't really need it in Though its fine by me if you don't want to do it in this PR There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I assumed GriptapeCloud used a non-attribute trace_provider on purpose. If we are OK with GriptapeCloud using the OpenTelemetry tracer_provider, then happy to. Just not clear why it used its own trace_provider in the first place There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
span_processor: SpanProcessor = field(kw_only=True) | ||
service_version: Optional[str] = field(default=None, kw_only=True) | ||
deployment_env: Optional[str] = field(default=None, kw_only=True) | ||
trace_provider: TracerProvider = field( | ||
default=Factory( | ||
lambda self: TracerProvider(resource=Resource(attributes={"service.name": self.service_name})), | ||
lambda self: self._trace_provider_factory(), | ||
takes_self=True, | ||
), | ||
kw_only=True, | ||
) | ||
_tracer: Optional[Tracer] = None | ||
_root_span_context_manager: Any = None | ||
|
||
def _trace_provider_factory(self) -> TracerProvider: | ||
attributes = {"service.name": self.service_name} | ||
if self.service_version: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use explicit |
||
attributes["service.version"] = self.service_version | ||
if self.deployment_env: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
attributes["deployment.environment"] = self.deployment_env | ||
return TracerProvider(resource=Resource(attributes=attributes)) # pyright: ignore[reportArgumentType] | ||
|
||
def __attrs_post_init__(self) -> None: | ||
self.trace_provider.add_span_processor(self.span_processor) | ||
self._tracer = get_tracer(self.service_name, tracer_provider=self.trace_provider) | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import os | ||
from unittest import mock | ||
|
||
from griptape.drivers import DatadogObservabilityDriver | ||
|
||
|
||
class TestDatadogTelemetryObservabilityDriver: | ||
def test_init(self): | ||
driver = DatadogObservabilityDriver() | ||
|
||
assert driver.service_name == "griptape" | ||
assert driver.datadog_agent_endpoint == "http://localhost:4318" | ||
|
||
@mock.patch.dict(os.environ, {"DD_AGENT_ENDPOINT": "http://griptape.ai:1234"}) | ||
def test_init_env_var_dd_agent(self): | ||
driver = DatadogObservabilityDriver() | ||
|
||
assert driver.datadog_agent_endpoint == "http://griptape.ai:1234" | ||
|
||
def test_init_set_dd_agent(self): | ||
driver = DatadogObservabilityDriver(datadog_agent_endpoint="http://griptape.ai:4321") | ||
|
||
assert driver.datadog_agent_endpoint == "http://griptape.ai:4321" | ||
|
||
def test_init_set_service_name(self): | ||
driver = DatadogObservabilityDriver(service_name="test") | ||
|
||
assert driver.service_name == "test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use f-string instead of string concatenation.