Add flake8-logging and flake8-logging-format ruff rules #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
force-pushed
the
feature/ruff-logging
branch
from
2b3d966
to
a5d0f77
Compare
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
dylanholmes
reviewed
Jul 18, 2024
| logging.error(f"Error while loading entry: {e}") | ||
| logging.exception("Error while loading entry: %s", e) |
There was a problem hiding this comment.
I was going to complain about not using f-strings, but the argument in G004 about deferring string formatting speaks to me. TIL
(Would be even cooler if the formatted values could be lazily computed too)
griptape/tasks/actions_subtask.py
Outdated
| self.structure.logger.error(f"Subtask {self.origin_task.id}\nError parsing tool action: {e}") | ||
| self.structure.logger.error("Subtask %s\nError parsing tool action: %s", self.id, e) |
There was a problem hiding this comment.
Was self.origin_task.id -> self.id intentional?
| self.structure.logger.info(f"{self.__class__.__name__} {self.id}\nInput: {self.input.to_text()}") | ||
| self.structure.logger.info("%s %s\nInput: %s", self.__class__.__name__, self.id, self.input.to_text()) |
There was a problem hiding this comment.
This is one case where I might favor readability over the micro-optimization of lazy string formatting, but 🤷
collindutter
force-pushed
the
feature/ruff-logging
branch
from
a5d0f77
to
3213e06
Compare
dylanholmes
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add flake8-logging and flake8-logging-format ruff rules.
Issue ticket number and link
#995