Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: forms inhibited when summary selected and vice versa #1037

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: forms inhibited when summary selected and vice versa #1037

wants to merge 3 commits into from

Conversation

hexaltation
Copy link
Collaborator

fixes #967

Following behaviour proposed by @dsagal in the issue

It would make sense to me if in the "Add Widget" panel, "Sum" icon were disabled when Form widget is chosen, and if "Form" option were greyed out when "Sum" is selected.

fflorent
fflorent suggested changes Jun 26, 2024
View reviewed changes
app/client/ui/PageWidgetPicker.ts Outdated Show resolved Hide resolved
app/client/ui/PageWidgetPicker.ts Outdated Show resolved Hide resolved
app/client/ui/PageWidgetPicker.ts Outdated Show resolved Hide resolved
app/client/ui/PageWidgetPicker.ts Outdated Show resolved Hide resolved
app/client/ui/PageWidgetPicker.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CamilleLegeron CamilleLegeron Awaiting requested review from CamilleLegeron

@fflorent fflorent Awaiting requested review from fflorent

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
anct
Projects
French administration Board
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forms created from a Summary Table are bugged
2 participants
@hexaltation @fflorent