Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable external contributors to create previews #1068

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

SleepyLeslie
Copy link
Collaborator

@SleepyLeslie SleepyLeslie commented Jun 26, 2024

This PR reorganizes previews so they can be made for PRs from outside contributors.
The idea is to build a Docker image on the pull_request trigger (doesn't require write access to target repo / read access to our secrets), and later deploy it directly to fly.io.

@SleepyLeslie SleepyLeslie added the preview Launch preview deployment of this PR label Jun 26, 2024
@SleepyLeslie SleepyLeslie marked this pull request as draft June 26, 2024 22:11
@SleepyLeslie SleepyLeslie changed the title Dummy PR Enable external contributors to use previews Jun 28, 2024
@SleepyLeslie SleepyLeslie changed the title Enable external contributors to use previews Enable external contributors to create previews Jun 28, 2024
@SleepyLeslie SleepyLeslie marked this pull request as ready for review June 28, 2024 21:04
@SleepyLeslie
Copy link
Collaborator Author

To test this PR:

  • Make your own fork of grist-core.
  • In your fork, create a secret named FLY_API_TOKEN. Paste your fly.io API token there.
  • Fork your grist-core fork and create a PR from there to your grist-core fork.
  • Attach the preview label to your PR.

@SleepyLeslie SleepyLeslie removed the preview Launch preview deployment of this PR label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant