Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Transactions #12

Closed
4 tasks done
grncdr opened this issue Dec 18, 2012 · 2 comments
Closed
4 tasks done

Tests for Transactions #12

grncdr opened this issue Dec 18, 2012 · 2 comments
Labels

Comments

@grncdr
Copy link
Owner

grncdr commented Dec 18, 2012

Tests for:

  • auto-rollback
  • connections are returned to pool
  • transactions unusable after rollback/commit
  • no synchronous errors

Really, the Transaction might need to be rewritten using a better tested state machine library than the one I hacked up in a hurry. I'm open to recommendations if anybody has a preferred lib.

@brianc
Copy link

brianc commented Dec 19, 2012

This is slightly off topic but postgres supports save points within transactions. Any thought to supporting those?

@grncdr
Copy link
Owner Author

grncdr commented Dec 19, 2012

I've thought about it, but it's probably a 1.x.y feature.

One option to consider would be putting the Transaction object into it's own module (it's pretty standalone already). This would make it easy for the drivers to implement .begin themselves and extend the Transaction object as necessary without depending on the connection pool bits.

That being said, I'm perfectly fine with having driver-specific Transaction extensions inside any-db itself.

@grncdr grncdr closed this as completed Apr 25, 2013
grncdr added a commit that referenced this issue Jul 13, 2018
Update mysql to version 2.13.0 🚀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants