-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
descriptor.File should not contain nil SourceCodeInfo #3542
Comments
Thanks for the bug report, this is definitely concerning. It doesn't seem to be happening in our own tests, so I'm not sure what could be going on here. This code also hasn't changed in the last 6 years as far as I can tell. What version of protoc are you using? I'll have a look again to see if any changes stand out to me but at the moment I'm at a loss. |
protoc --version |
I'm forking the code to see if I can at least print the filename that is causing the problem and get more details about why this is happening. |
Ah, I expect it's a0ab79a |
Looks like we might need to explicitly set the source code info like we used to |
CC @aimuz |
Can you try building from
|
That fixes the issue. Thank you. |
Just an FYI, I did my change to report the errant files and got this when running
|
I'll release 2.17.1 with this fix, thank you! |
nice |
🐛 Bug Report
As of v2.17.0 we have started getting errors when running protoc-gen-openapiv2.
We get the message: “descriptor.File should not contain nil SourceCodeInfo” with no other details about the issue.
It seems to be coming from here: https://github.com/grpc-ecosystem/grpc-gateway/blob/main/protoc-gen-openapiv2/internal/genopenapi/template.go#L2333
If I revert back to v2.16.2, everything works fine. I can't tell if this is a problem or not.
To Reproduce
Expected behavior
Works like v2.16.2
Alternatively, tell us which file is having the issue.
Actual Behavior
results in a set of these messages for each proto file:
descriptor.File should not contain nil SourceCodeInfo
descriptor.File should not contain nil SourceCodeInfo
descriptor.File should not contain nil SourceCodeInfo
descriptor.File should not contain nil SourceCodeInfo
descriptor.File should not contain nil SourceCodeInfo
descriptor.File should not contain nil SourceCodeInfo
descriptor.File should not contain nil SourceCodeInfo
descriptor.File should not contain nil SourceCodeInfo
descriptor.File should not contain nil SourceCodeInfo
Your Environment
Mac OS - Darwin Kernel Version 22.6.0: Wed Jul 5 22:22:52 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T8103 arm64
go version go1.20.7 darwin/arm64
The text was updated successfully, but these errors were encountered: