Implement fetch based transport #549
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 30, 2022 20:51
…s a Uint8Array to support values larger than 127 which string encoding was messing up.
…nd marshal to javascript Uint8Array.
…aborted so that we stop reading gracefully.
…h some minor changes because of the events. Also made some minor tweaks to fetch to have a String response for the tests like xhr.
added 5 commits
May 5, 2022 09:31
…ut not with 2.16 which is what I was using during development.
…an iterable type. This apparently changed with flutter 3.0.
…namic javascript types because the resulting code does not work when building web in release mode.
|
I created an issue for the dart SDK with my last change (5a8818b): |
|
@jbrownsw I just tested this branch today (had to add one no-op implementation for the updated main branch) and it seems to work well in debug and release mode. Perhaps your original issues have been since resolved? Or maybe I'm not hitting the repro condition? For me, it makes my jpeg video stream actually usable in grpc-web, so would love to see it merged :) |
|
I don't work at the company that I developed this for so I can't test it, but perhaps @gawmanarnar can get someone to confirm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially to resolve issue #511. It's designed to be very similar to the existing xhr transport, but with my own
FetchHttpRequestto replace theHttpRequesttype. I was a little lazy on the events so they differ a bit, but I could change them to match those used by xhr to make them even more similar. I could also remove some of the code duplication and the transport stream and connection could be shared with only FetchHttpRequest or HttpRequest being the difference and that could be passed in as a function or a generic type parameter. Finally the last thing I wasn't sure of is if you would want this as a complete replacement for xhr or if you'd rather them coexist so people can switch between them etc. So web_channel.dart will need to be updated based on what route you want to go there.I'm already using this as a drop in replacement for our app and haven't noticed any differences other than the memory growth for streams disappearing.