Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy functionality #657

Merged
merged 13 commits into from
Aug 23, 2023
Merged

Add proxy functionality #657

merged 13 commits into from
Aug 23, 2023

Conversation

mosuem
Copy link
Contributor

@mosuem mosuem commented Aug 4, 2023

Closes #33.

@mosuem mosuem self-assigned this Aug 4, 2023
@mosuem mosuem requested a review from mraleph August 18, 2023 09:42
mraleph
mraleph approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@mraleph mraleph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some comments.

I wonder if the functionality for creating HTTP/2 connections over proxies actually belongs to http2 package itself?

But maybe it's okay to have it here as well for now.

lib/src/client/http2_connection.dart Outdated Show resolved Hide resolved
lib/src/client/http2_connection.dart Outdated Show resolved Hide resolved
lib/src/client/proxy.dart Show resolved Hide resolved
@mosuem mosuem merged commit 4ccd8a0 into master Aug 23, 2023
12 checks passed
@mosuem mosuem deleted the addProxy branch August 23, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraleph mraleph mraleph approved these changes

Assignees

@mosuem mosuem

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for proxies
2 participants
@mosuem @mraleph