-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: add WithConnectParams to configure connection backoff and timeout #2960
Merged
+176
−79
Commits on Sep 30, 2019
-
Implement missing pieces for connection backoff.
Spec can be found here: https://github.com/grpc/grpc/blob/master/doc/connection-backoff.md Summary of changes: * Added a new type (marked experimental), ConnectParams, which contains the knobs defined in the spec (except for minConnectTimeout). * Added a new API (marked experimental), WithConnectParams() to return a DialOption to dial with the provided parameters. * Added new fields to the implementation of the exponential backoff in internal/backoff which mirror the ones in ConnectParams. * Marked existing APIs WithBackoffMaxDelay() and WithBackoffConfig() as deprecated. * Added a default exponential backoff implementation, for easy use of internal callers.
Configuration menu - View commit details
-
Copy full SHA for 32275fc - Browse repository at this point
Copy the full SHA 32275fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8b4003 - Browse repository at this point
Copy the full SHA f8b4003View commit details -
Added a new backoff package which defines the backoff configuration options, and is used by both the grpc package and the internal/backoff package. This allows us to have all backoff related options in a separate package.
Configuration menu - View commit details
-
Copy full SHA for 0f7db76 - Browse repository at this point
Copy the full SHA 0f7db76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0115f00 - Browse repository at this point
Copy the full SHA 0115f00View commit details -
Configuration menu - View commit details
-
Copy full SHA for dea6444 - Browse repository at this point
Copy the full SHA dea6444View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5998d1 - Browse repository at this point
Copy the full SHA f5998d1View commit details
Commits on Oct 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 3fce38e - Browse repository at this point
Copy the full SHA 3fce38eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1a1470 - Browse repository at this point
Copy the full SHA e1a1470View commit details
Commits on Oct 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ebebd7d - Browse repository at this point
Copy the full SHA ebebd7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc7872c - Browse repository at this point
Copy the full SHA cc7872cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.