Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add profiling to gRPC #3130

Closed
wants to merge 30 commits into from
Closed

[WIP] add profiling to gRPC #3130

wants to merge 30 commits into from

Conversation

adtac
Copy link
Contributor

@adtac adtac commented Oct 29, 2019

This is very much still in development and is subject to massive changes in the near future. Some of the documentation might be outdated, missing, or wrong; I'll fix that soon. The feature itself is experimental and might change rapidly even after merging.

(This won't even build because I'm using runtime.GoId(), which is a local hack that doesn't exist in actual Go.)

I've squashed about 20 local commits to arrive at these 5-6 logically atomic commits; I still have a copy of those 20 commits in case anyone wants them. I'll add new commits on top of this for now and squash them with the appropriate commits later. Or we can just choose to squash everything into one commit (but I think that would lose some information).

Note: WIP

@adtac adtac changed the title add profiling to gRPC [WIP] add profiling to gRPC Oct 29, 2019
@adtac
Copy link
Contributor Author

adtac commented Nov 7, 2019

This can now be closed:

internal: #3158

hooks: #3159

service: #3160

cmd: #3161

@adtac adtac closed this Nov 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant