xds: skip callback if xds client reports error #3240
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @easwars and @menghanl)
xds/internal/balancer/xds_client_test.go, line 208 at r1 (raw file):
}, attributes.New(xdsinternal.XDSClientID, c), )
Should we make sure that the fakeXDS server actually receives the EDS request before invoking the callback?
|
Also, do you think it would make sense to wait for #3233 and update the test here? Or we can batch up the cleanups, however. |
Errors will be handled specifically, depending on whether it's a connection error or other types of errors. Without this fix, balancer's callback will be called with <nil> update, causing nil panic later.
menghanl
force-pushed
the
xds_update_err_nil
branch
from
df1002b
to
053537e
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @easwars and @menghanl)
xds/internal/balancer/xds_client_test.go, line 208 at r1 (raw file):
Previously, easwars (Easwar Swaminathan) wrote…
Should we make sure that the fakeXDS server actually receives the EDS request before invoking the callback?
Done.
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewable status:
Errors will be handled specifically, depending on whether it's a
connection error or other types of errors.
Without this fix, balancer's callback will be called with update,
causing nil panic later.
This change is