Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add benchmark test for FromIncomingContext and ValueFromIncomingContext #6117

Merged
merged 3 commits into from
Mar 15, 2023
Merged

add benchmark test for FromIncomingContext and ValueFromIncomingContext #6117

merged 3 commits into from
Mar 15, 2023

Conversation

wenxuwan
Copy link
Contributor

@wenxuwan wenxuwan commented Mar 13, 2023 •
edited by easwars
Loading

add benchmarktest for FromIncomingContext and ValueFromIncomingContext, and the result is:

goos: darwin
goarch: amd64
pkg: google.golang.org/grpc/metadata
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
BenchmarkFromIncomingContext-12                       4657538               260.4 ns/op           416 B/op          3 allocs/op
BenchmarkValueFromIncomingContext-12            28756804                38.28 ns/op           16 B/op          1 allocs/op
PASS
ok      google.golang.org/grpc/metadata 3.475s

RELEASE NOTES: none

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 13, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@wenxuwan wenxuwan changed the title add benchmarktest for FromIncomingContext and ValueFromIncomingContext add benchmark test for FromIncomingContext and ValueFromIncomingContext Mar 13, 2023
easwars
easwars reviewed Mar 14, 2023
View reviewed changes
metadata/metadata_test.go Outdated Show resolved Hide resolved
metadata/metadata_test.go Show resolved Hide resolved
@easwars easwars added this to the 1.54 Release milestone Mar 15, 2023
zasweq
zasweq approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zasweq zasweq merged commit 6f44ae8 into grpc:master Mar 15, 2023
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@easwars easwars easwars approved these changes

@zasweq zasweq zasweq approved these changes

Assignees

@wenxuwan wenxuwan

Labels
Type: Testing
Projects
None yet
Milestone
1.54 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@wenxuwan @easwars @zasweq