stats/opencensus: Handle PickerUpdated to avoid "Received unexpected stats" error
#7153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
changed the title
PickerUpdated to avoid "Received unexpected stats" errorPickerUpdated to avoid "Received unexpected stats" error
zasweq
approved these changes
Apr 19, 2024
stats/opencensus/stats.go
Outdated
| // Headers and Trailers are not relevant to the measures, as the | ||
| // measures concern number of messages and bytes for messages. This | ||
| // aligns with flow control. | ||
| // Updated pickers are not relevant to the measures, either. |
There was a problem hiding this comment.
Nit: please wrap to 80 chars, as above.
There was a problem hiding this comment.
I would prefer to make the whole comment flow better: "Headers, Trailers, and picker updates are not relevant......"
townba
force-pushed
the
townba-pickerupdated
branch
from
d147c8f
to
ff8c129
Compare
|
PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: None