Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security/advancedtls: remove Go1.19 build constraints #7404

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Jul 10, 2024

This helps get rid of a vet failure.

RELEASE NOTES: none

@easwars easwars requested a review from gtcooke94 July 10, 2024 22:06
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Jul 10, 2024
@easwars easwars added this to the 1.66 Release milestone Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (eff3e67) to head (5b5b1a5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7404      +/-   ##
==========================================
+ Coverage   81.33%   81.35%   +0.02%     
==========================================
  Files         348      348              
  Lines       26752    26752              
==========================================
+ Hits        21758    21764       +6     
+ Misses       3791     3790       -1     
+ Partials     1203     1198       -5     

see 12 files with indirect coverage changes

@dfawley dfawley assigned easwars and unassigned gtcooke94 and dfawley Jul 10, 2024
@easwars easwars merged commit 48b7581 into grpc:master Jul 10, 2024
13 checks passed
@easwars easwars deleted the delete_crl branch July 10, 2024 22:38
printchard pushed a commit to printchard/grpc-go that referenced this pull request Jul 11, 2024
printchard pushed a commit to printchard/grpc-go that referenced this pull request Jul 30, 2024
printchard pushed a commit to printchard/grpc-go that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants