Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using native maven_jar rule in grpc #5327

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Conversation

dkelmer
Copy link
Contributor

@dkelmer dkelmer commented Feb 6, 2019

See bazelbuild/bazel#6799 for more information

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@dkelmer
Copy link
Contributor Author

dkelmer commented Feb 6, 2019

Does Google have a corporate CLA for linuxfoundation or should I join as an individual?

@dkelmer
Copy link
Contributor Author

dkelmer commented Feb 6, 2019

I mailed this internally, so I'm closing the PR

@dkelmer dkelmer closed this Feb 6, 2019
@dkelmer dkelmer reopened this Feb 6, 2019
@dkelmer
Copy link
Contributor Author

dkelmer commented Feb 6, 2019

Reopened and joined the google github org for the CLA

@dapengzhang0
Copy link
Member

ping CLA

@ejona86
Copy link
Member

ejona86 commented Feb 7, 2019

Google has a corporate CLA.

@dkelmer, how was this generated? To get the licenses right it seems there was some tool.

@dkelmer
Copy link
Contributor Author

dkelmer commented Feb 7, 2019

I must admit that I manually googled the jars individually and copied the license information from maven central to the bzl file

@ejona86
Copy link
Member

ejona86 commented Feb 7, 2019

@dkelmer, oh, in that case thank you for all the effort.

Have you gone through the process for the CLA? I think you need github to know associate your @google.com email address with your account and then use the "Sign up to contribute to this project as an employee" link at the CLA page. I don't think being part of the Google org on Github has anything to do with it.

@dkelmer
Copy link
Contributor Author

dkelmer commented Feb 7, 2019

ping CLA

@dkelmer
Copy link
Contributor Author

dkelmer commented Feb 7, 2019

@dkelmer, oh, in that case thank you for all the effort.

You're welcome :)

Have you gone through the process for the CLA? I think you need github to know associate your @google.com email address with your account and then use the "Sign up to contribute to this project as an employee" link at the CLA page. I don't think being part of the Google org on Github has anything to do with it.

I think I just did it

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Feb 7, 2019
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Feb 7, 2019
@ejona86
Copy link
Member

ejona86 commented Feb 7, 2019

Yay! The CLA is happy. I forgot to trigger the Kokoro builds earlier. After they finish I'll merge.

@dkelmer
Copy link
Contributor Author

dkelmer commented Feb 7, 2019

Seems like kokoro passed :)

@ejona86 ejona86 merged commit e4045f8 into grpc:master Feb 7, 2019
@ejona86
Copy link
Member

ejona86 commented Feb 7, 2019

@dkelmer, thank you!

@lock lock bot locked as resolved and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants