-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version flag and version info in generated code #1231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meling Thanks so much for the change!! Much appreciated! :)
(It's totally ok that we have to manually update the version file for now.. probably the best thing that can be done for now :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much again! LGTM just a few tiny nits and good to merge! :D
Note: I added "versioned" comments also for PS: Feel free to squash the commits into one for the merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your contribution and your patience on the comments! Much appreciated! :)
BTW i've build a few binaries (for all 3 platforms) here: In case anyone is interested in downloading them :) |
Fixes #1216.
Example output (edited):
Caveat: Needs manual updating of newly added
version.h
file. The process of deciding the version number is not clear to me, and whether or not it could be automated somehow.