Put thread creation and join under lock #11837
Merged
+18
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgquintas
force-pushed
the
thread_manager_join
branch
from
f1b3dec
to
aef267b
Compare
sreecha
approved these changes
Jul 15, 2017
sreecha
approved these changes
Jul 15, 2017
|
|
|
Issues: #11188 |
|
@nicolasnoble can you merge this? How come I can't anymore? |
markdroth
approved these changes
Jul 17, 2017
There was a problem hiding this comment.
The reason you couldn't merge this is that the github codeowners system is too dumb to realize that the PR's author is one of the owners, so it is requiring an approval from one of the other owners (me or Craig). I'm approving, so you should be able to merge now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.