Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render JSON tests fixes #2248

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Render JSON tests fixes #2248

merged 1 commit into from
Aug 23, 2022

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Aug 22, 2022 •
edited
Loading

Description

Update render JSON tests to use different directories and avoid parallel execution errors

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Migration Guide

zackproser
zackproser approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@zackproser zackproser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denis256 denis256 merged commit b98bc95 into master Aug 23, 2022
@denis256 denis256 deleted the bug/fix-render-json-tests branch August 23, 2022 08:53
@renovate renovate bot mentioned this pull request Nov 2, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackproser zackproser zackproser approved these changes

@yorinasub17 yorinasub17 Awaiting requested review from yorinasub17

@rhoboat rhoboat Awaiting requested review from rhoboat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis256 @zackproser