forked from flutter/flutter
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use hint freed specifically for image disposal (flutter#20754)
* Use hint freed specifically for image disposal
- Loading branch information
Showing
22 changed files
with
351 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| #ifndef FLUTTER_LIB_UI_HINT_FREED_DELEGATE_H_ | ||
| #define FLUTTER_LIB_UI_HINT_FREED_DELEGATE_H_ | ||
|
|
||
| namespace flutter { | ||
|
|
||
| class HintFreedDelegate { | ||
| public: | ||
| //---------------------------------------------------------------------------- | ||
| /// @brief Notifies the engine that native bytes might be freed if a | ||
| /// garbage collection ran at the next NotifyIdle period. | ||
| /// | ||
| /// @param[in] size The number of bytes freed. This size adds to any | ||
| /// previously supplied value, rather than replacing. | ||
| /// | ||
| virtual void HintFreed(size_t size) = 0; | ||
| }; | ||
|
|
||
| } // namespace flutter | ||
|
|
||
| #endif // FLUTTER_LIB_UI_HINT_FREED_DELEGATE_H_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| #define FML_USED_ON_EMBEDDER | ||
|
|
||
| #include "flutter/common/task_runners.h" | ||
| #include "flutter/fml/synchronization/waitable_event.h" | ||
| #include "flutter/lib/ui/painting/image.h" | ||
| #include "flutter/lib/ui/painting/picture.h" | ||
| #include "flutter/runtime/dart_vm.h" | ||
| #include "flutter/shell/common/shell_test.h" | ||
| #include "flutter/shell/common/thread_host.h" | ||
| #include "flutter/testing/testing.h" | ||
|
|
||
| namespace flutter { | ||
| namespace testing { | ||
|
|
||
| class ImageDisposeTest : public ShellTest { | ||
| public: | ||
| template <class T> | ||
| T* GetNativePeer(Dart_NativeArguments args, int index) { | ||
| auto handle = Dart_GetNativeArgument(args, index); | ||
| intptr_t peer = 0; | ||
| EXPECT_FALSE(Dart_IsError(Dart_GetNativeInstanceField( | ||
| handle, tonic::DartWrappable::kPeerIndex, &peer))); | ||
| return reinterpret_cast<T*>(peer); | ||
| } | ||
|
|
||
| // Used to wait on Dart callbacks or Shell task runner flushing | ||
| fml::AutoResetWaitableEvent message_latch_; | ||
|
|
||
| fml::AutoResetWaitableEvent picture_finalizer_latch_; | ||
| static void picture_finalizer(void* isolate_callback_data, void* peer) { | ||
| auto latch = reinterpret_cast<fml::AutoResetWaitableEvent*>(peer); | ||
| latch->Signal(); | ||
| } | ||
|
|
||
| sk_sp<SkPicture> current_picture_; | ||
| sk_sp<SkImage> current_image_; | ||
| }; | ||
|
|
||
| TEST_F(ImageDisposeTest, ImageReleasedAfterFrame) { | ||
| auto native_capture_image_and_picture = [&](Dart_NativeArguments args) { | ||
| CanvasImage* image = GetNativePeer<CanvasImage>(args, 0); | ||
| Picture* picture = GetNativePeer<Picture>(args, 1); | ||
| ASSERT_FALSE(image->image()->unique()); | ||
| ASSERT_FALSE(picture->picture()->unique()); | ||
| current_image_ = image->image(); | ||
| current_picture_ = picture->picture(); | ||
|
|
||
| Dart_NewFinalizableHandle(Dart_GetNativeArgument(args, 1), | ||
| &picture_finalizer_latch_, 0, &picture_finalizer); | ||
| }; | ||
|
|
||
| auto native_on_begin_frame_done = [&](Dart_NativeArguments args) { | ||
| message_latch_.Signal(); | ||
| }; | ||
|
|
||
| Settings settings = CreateSettingsForFixture(); | ||
| auto task_runner = CreateNewThread(); | ||
| TaskRunners task_runners("test", // label | ||
| GetCurrentTaskRunner(), // platform | ||
| task_runner, // raster | ||
| task_runner, // ui | ||
| task_runner // io | ||
| ); | ||
|
|
||
| AddNativeCallback("CaptureImageAndPicture", | ||
| CREATE_NATIVE_ENTRY(native_capture_image_and_picture)); | ||
| AddNativeCallback("OnBeginFrameDone", | ||
| CREATE_NATIVE_ENTRY(native_on_begin_frame_done)); | ||
|
|
||
| std::unique_ptr<Shell> shell = CreateShell(std::move(settings), task_runners); | ||
|
|
||
| ASSERT_TRUE(shell->IsSetup()); | ||
|
|
||
| SetViewportMetrics(shell.get(), 800, 600); | ||
|
|
||
| shell->GetPlatformView()->NotifyCreated(); | ||
|
|
||
| auto configuration = RunConfiguration::InferFromSettings(settings); | ||
| configuration.SetEntrypoint("pumpImage"); | ||
|
|
||
| shell->RunEngine(std::move(configuration), [&](auto result) { | ||
| ASSERT_EQ(result, Engine::RunStatus::Success); | ||
| }); | ||
|
|
||
| message_latch_.Wait(); | ||
|
|
||
| ASSERT_TRUE(current_picture_); | ||
| ASSERT_TRUE(current_image_); | ||
|
|
||
| // Simulate a large notify idle, as the animator would do | ||
| // when it has no frames left. | ||
| // On slower machines, this is especially important - we capture that | ||
| // this happens normally in devicelab bnechmarks like large_image_changer. | ||
| NotifyIdle(shell.get(), Dart_TimelineGetMicros() + 100000); | ||
|
|
||
| picture_finalizer_latch_.Wait(); | ||
|
|
||
| // Force a drain the SkiaUnrefQueue. | ||
| message_latch_.Reset(); | ||
| task_runner->PostTask([&, io_manager = shell->GetIOManager()]() { | ||
| io_manager->GetSkiaUnrefQueue()->Drain(); | ||
| message_latch_.Signal(); | ||
| }); | ||
| message_latch_.Wait(); | ||
|
|
||
| EXPECT_TRUE(current_picture_->unique()); | ||
| current_picture_.reset(); | ||
|
|
||
| EXPECT_TRUE(current_image_->unique()); | ||
| current_image_.reset(); | ||
|
|
||
| shell->GetPlatformView()->NotifyDestroyed(); | ||
| DestroyShell(std::move(shell), std::move(task_runners)); | ||
| } | ||
|
|
||
| } // namespace testing | ||
| } // namespace flutter |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.