Merge pull request #4 from flutter/master

Updating flutter fork

.cirrus.yml

@@ -41,7 +41,20 @@ task:
         SHARD: deploy_gallery
         GOOGLE_DEVELOPER_SERVICE_ACCOUNT_ACTOR_FASTLANE: ENCRYPTED[d9ac1462c3c556fc2f8165c9d5566a16497d8ebc38a50357f7f3abf136b7f83e1d1d76dde36fee356cb0f9ebf7a89346]
         ANDROID_GALLERY_UPLOAD_KEY: ENCRYPTED[0f2aca35f05b26add5d9edea2a7449341269a2b7e22d5c667f876996e2e8bc44ff1369431ebf73b7c5581fd95d0e5902]
-      test_script: ./dev/bots/deploy_gallery.sh
+      test_script:
+        # Unsetting CIRRUS_CHANGE_MESSAGE and CIRRUS_COMMIT_MESSAGE as they
+        # might include non-ASCII characters which makes Gradle crash.
+        # See: https://github.com/flutter/flutter/issues/24935
+        # This is a temporary workaround until we figure how to properly configure
+        # a UTF8 locale on Cirrus (or until the Gradle bug is fixed).
+        # TODO(amirh): Set the locale to UTF8.
+        - echo "$CIRRUS_CHANGE_MESSAGE" > /tmp/cirrus_change_message.txt
+        - echo "$CIRRUS_COMMIT_MESSAGE" > /tmp/cirrus_commit_message.txt
+        - export CIRRUS_CHANGE_MESSAGE=""
+        - export CIRRUS_COMMIT_MESSAGE=""
+        - ./dev/bots/deploy_gallery.sh
+        - export CIRRUS_CHANGE_MESSAGE=`cat /tmp/cirrus_change_message.txt`
+        - export CIRRUS_COMMIT_MESSAGE=`cat /tmp/cirrus_commit_message.txt`
     - name: analyze
       test_script:
         - dart --enable-asserts ./dev/bots/analyze.dart
@@ -112,6 +125,7 @@ task:
     fingerprint_script: echo %OS% & type bin\internal\engine.version
   setup_script:
     - bin\flutter.bat config --no-analytics
+    - bin\flutter.bat doctor -v
     - bin\flutter.bat update-packages
     - git fetch origin master
   test_all_script:
@@ -195,7 +209,9 @@ task:
     - name: $SHARD-macos
       env:
         matrix:
-          - SHARD: integration_tests
+          # The flakiness of this target has increased beyond tolerable levels. Until we can stabilize it,
+          # keep the shard disabled.
+          # - SHARD: integration_tests
           - SHARD: build_tests
             COCOAPODS_DISABLE_STATS: true
             FLUTTER_FRAMEWORK_DIR: "/tmp/flutter sdk/bin/cache/artifacts/engine/ios/"
@@ -226,6 +242,7 @@ task:
     fingerprint_script: echo $OS; cat bin/internal/engine.version
   setup_script:
     - bin/flutter config --no-analytics
+    - bin/flutter doctor -v
     - bin/flutter update-packages
   test_all_script: |
     ulimit -S -n 2048 # https://github.com/flutter/flutter/issues/2976

.github/ISSUE_TEMPLATE/ACTIVATION.md

@@ -3,6 +3,9 @@ name: I am having difficulty installing Flutter or getting it to work
 about: You have run into problems while downloading or installing Flutter, or the
   "flutter" tool is crashing, or you are running into some other issue before even
   being able to use "flutter run".
+title: ''
+labels: ''
+assignees: ''
 
 ---
 
@@ -11,12 +14,12 @@ about: You have run into problems while downloading or installing Flutter, or th
      If you are looking for support, please check out our documentation
      or consider asking a question on Stack Overflow:
       * https://flutter.dev/
-      * https://docs.flutter.io/
+      * https://api.flutter.dev/
       * https://stackoverflow.com/questions/tagged/flutter?sort=frequent
 
      If you have found a bug or if our documentation doesn't have an answer
      to what you're looking for, then fill our the template below. Please read
-     our guide to filing a bug first:  https://flutter.dev/bug-reports/
+     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
 -->
 
 ## Steps to Reproduce

.github/ISSUE_TEMPLATE/BUG.md

@@ -2,6 +2,9 @@
 name: I have a problem with my Flutter application.
 about: You are writing an application with Flutter but the application is crashing
   or throws an exception, a widget is buggy, or something looks wrong.
+title: ''
+labels: ''
+assignees: ''
 
 ---
 
@@ -10,12 +13,12 @@ about: You are writing an application with Flutter but the application is crashi
      If you are looking for support, please check out our documentation
      or consider asking a question on Stack Overflow:
       * https://flutter.dev/
-      * https://docs.flutter.io/
+      * https://api.flutter.dev/
       * https://stackoverflow.com/questions/tagged/flutter?sort=frequent
 
      If you have found a bug or if our documentation doesn't have an answer
      to what you're looking for, then fill our the template below. Please read
-     our guide to filing a bug first:  https://flutter.dev/bug-reports/
+     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
 -->
 
 ## Steps to Reproduce

.github/ISSUE_TEMPLATE/SUPPORT.md

@@ -2,14 +2,17 @@
 name: I want help writing my application
 about: You have a question for how to achieve a particular effect, or you need help
   with using a particular API.
+title: ''
+labels: ''
+assignees: ''
 
 ---
 
 <!-- Thank you for using Flutter!
 
      Please check out our documentation first:
       * https://flutter.dev/
-      * https://docs.flutter.io/
+      * https://api.flutter.dev/
 
      If you can't find the answer there, please consider asking a question on
      the Stack Overflow Web site:

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,46 @@
+---
+name: Feature request
+about: Suggest a new idea for Flutter
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+<!-- Thank you for using Flutter!
+
+     If you are looking for support, please check out our documentation
+     or consider asking a question on Stack Overflow:
+      * https://flutter.dev/
+      * https://api.flutter.dev/
+      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent
+
+     If you have found a bug or if our documentation doesn't have an answer
+     to what you're looking for, then fill our the template below. Please read
+     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
+-->
+
+## Use case
+
+<!--
+     Please tell us the problem you are running into that led to you wanting
+     a new feature.
+
+     Is your feature request related to a problem? Please give a clear and
+     concise description of what the problem is.
+
+     Describe alternative solutions you've considered. Is there a package
+     on pub.dartlang.org that already solves this?
+-->
+
+## Proposal
+
+<!--
+     Briefly but precisely describe what you would like Flutter to be able to do.
+
+     Consider attaching images showing what you are imagining.
+
+     Does this have to be provided by Flutter directly, or can it be provided
+     by a package on pub.dartlang.org? If so, maybe consider implementing and
+     publishing such a package rather than filing a bug.
+-->

.gitignore

@@ -85,6 +85,9 @@ unlinked_spec.ds
 **/ios/ServiceDefinitions.json
 **/ios/Runner/GeneratedPluginRegistrant.*
 
+# Coverage
+coverage/
+
 # Exceptions to above rules.
 !**/ios/**/default.mode1v3
 !**/ios/**/default.mode2v3

AUTHORS

@@ -39,3 +39,4 @@ Marco Scannadinari <m@scannadinari.co.uk>
 Frederik Schweiger <mail@flschweiger.net>
 Martin Staadecker <machstg@gmail.com>
 Igor Katsuba <katsuba.igor@gmail.com>
+Diego Velásquez <diego.velasquez.lopez@gmail.com>

bin/internal/engine.version

@@ -1 +1 @@
-7d1da567434a820853ed6fae1f6ed65b9de5ba4f
+ef2bed65db22b1ce3d05947d5cfa3927eb6fa975

bin/internal/fuchsia.version

@@ -0,0 +1 @@
+mfXzGfxNWcf6BHsv083b56vQcj96yCo0exBFBdjE4gMC

bin/internal/goldens.version

@@ -1 +1 @@
-3048ed023e5cc1d8e201f7abbba346e73cf5fa2c
+5e0cf0b9b347526d299718a4755e2d65cffacaba

dev/automated_tests/flutter_test/test_async_utils_guarded_expectation.txt

@@ -1,11 +1,19 @@
 <<skip until matching line>>
 ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
 The following assertion was thrown running a test:
-Guarded function conflict\. You must use "await" with all Future-returning test APIs\.
-The guarded "guardedHelper" function was called from .*dev/automated_tests/flutter_test/test_async_utils_guarded_test\.dart on line [0-9]+\.
-Then, the "expect" function was called from .*dev/automated_tests/flutter_test/test_async_utils_guarded_test\.dart on line [0-9]+\.
-The first function \(guardedHelper\) had not yet finished executing at the time that the second function \(expect\) was called\. Since both are guarded, and the second was not a nested call inside the first, the first must complete its execution before the second can be called\. Typically, this is achieved by putting an "await" statement in front of the call to the first\.
-If you are confident that all test APIs are being called using "await", and this expect\(\) call is not being called at the top level but is itself being called from some sort of callback registered before the guardedHelper method was called, then consider using expectSync\(\) instead\.
+Guarded function conflict\.
+You must use "await" with all Future-returning test APIs\.
+The guarded "guardedHelper" function was called from
+.*dev/automated_tests/flutter_test/test_async_utils_guarded_test\.dart[ \n]on[ \n]line[ \n][0-9]+\.
+Then, the "expect" function was called from
+.*dev/automated_tests/flutter_test/test_async_utils_guarded_test\.dart[ \n]on[ \n]line[ \n][0-9]+\.
+The first function \(guardedHelper\) had not yet finished executing at the time that the second
+function \(expect\) was called\. Since both are guarded, and the second was not a nested call inside
+the first, the first must complete its execution before the second can be called\. Typically, this is
+achieved by putting an "await" statement in front of the call to the first\.
+If you are confident that all test APIs are being called using "await", and this expect\(\) call is
+not being called at the top level but is itself being called from some sort of callback registered
+before the guardedHelper method was called, then consider using expectSync\(\) instead\.
 
 When the first function \(guardedHelper\) was called, this was the stack:
 <<skip until matching line>>

dev/automated_tests/flutter_test/test_async_utils_unguarded_expectation.txt

@@ -2,10 +2,16 @@
 <<skip until matching line>>
 ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
 The following assertion was thrown running a test:
-Guarded function conflict\. You must use "await" with all Future-returning test APIs\.
-The guarded method "pump" from class WidgetTester was called from .*dev/automated_tests/flutter_test/test_async_utils_unguarded_test.dart on line [0-9]+\.
-Then, it was called again from .*dev/automated_tests/flutter_test/test_async_utils_unguarded_test.dart on line [0-9]+\.
-The first method had not yet finished executing at the time that the second method was called\. Since both are guarded, and the second was not a nested call inside the first, the first must complete its execution before the second can be called\. Typically, this is achieved by putting an "await" statement in front of the call to the first\.
+Guarded function conflict\.
+You must use "await" with all Future-returning test APIs\.
+The guarded method "pump" from class WidgetTester was called from
+.*dev/automated_tests/flutter_test/test_async_utils_unguarded_test.dart[ \n]on[ \n]line[ \n][0-9]+\.
+Then, it was called again from
+.*dev/automated_tests/flutter_test/test_async_utils_unguarded_test.dart[ \n]on[ \n]line[ \n][0-9]+\.
+The first method had not yet finished executing at the time that the second method was called\. Since
+both are guarded, and the second was not a nested call inside the first, the first must complete its
+execution before the second can be called\. Typically, this is achieved by putting an "await"
+statement in front of the call to the first\.
 
 When the first method was called, this was the stack:
 <<skip until matching line>>

dev/automated_tests/pubspec.yaml

@@ -9,24 +9,24 @@ dependencies:
     sdk: flutter
   flutter_test:
     sdk: flutter
-  test: 1.6.1
+  test: 1.6.2
 
   analyzer: 0.35.4 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   args: 1.5.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
-  async: 2.1.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
+  async: 2.2.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   boolean_selector: 1.0.4 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   charcode: 1.1.2 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   collection: 1.14.11 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   convert: 2.1.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   crypto: 2.0.6 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   front_end: 0.1.14 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   glob: 1.1.7 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
-  http: 0.12.0+1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
+  http: 0.12.0+2 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   http_multi_server: 2.0.5 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   http_parser: 3.1.3 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   io: 0.3.3 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   js: 0.6.1+1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
-  json_rpc_2: 2.0.10 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
+  json_rpc_2: 2.1.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   kernel: 0.3.14 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   matcher: 0.12.5 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   meta: 1.1.6 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
@@ -39,20 +39,20 @@ dependencies:
   pedantic: 1.5.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   pool: 1.4.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   pub_semver: 1.4.2 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
-  quiver: 2.0.2 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
-  shelf: 0.7.4+1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
+  quiver: 2.0.3 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
+  shelf: 0.7.5 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   shelf_packages_handler: 1.0.4 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   shelf_static: 0.2.8 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
-  shelf_web_socket: 0.2.2+5 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
+  shelf_web_socket: 0.2.3 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   source_map_stack_trace: 1.1.5 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   source_maps: 0.10.8 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   source_span: 1.5.5 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   stack_trace: 1.9.3 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   stream_channel: 2.0.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   string_scanner: 1.0.4 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   term_glyph: 1.1.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
-  test_api: 0.2.4 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
-  test_core: 0.2.3 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
+  test_api: 0.2.5 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
+  test_core: 0.2.4 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   typed_data: 1.1.6 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   vector_math: 2.0.8 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
   vm_service_client: 0.2.6+1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
@@ -63,4 +63,4 @@ dependencies:
 flutter:
   uses-material-design: true
 
-# PUBSPEC CHECKSUM: df08
+# PUBSPEC CHECKSUM: 9823