-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note about finishing touches to "Set CSS Name and Use Exported Colors" section of 14th (CSS) chapter of the book. #1339
Conversation
…Colors" section of 14th (CSS) chapter of the book. Changes: - Remind reader to include "style.css" to "resources.gresource.xml" and call "load_css()" function in `connect_startup` handler. - Add anchors to listings/todo/3/main.rs file to be able to show them in the chapter: - connect_startup - load_css
@Hofer-Julian Could you please visually verify that my changes okay before merging PR? I haven't rendered the book with them. 😊 |
Please render it locally before opening pull requests. Do you have trouble with setting up the development environment? |
I will do. Sorry for that.
It seems all working fine and https://github.com/gtk-rs/gtk4-rs/tree/master/book#build-instructions is quite sufficient. It just was a night and a bit of laziness on my side. :) Rendered addition looks fine to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise :)
I see there is a missing space on the diff (green line), do you mind adding it? |
@Hofer-Julian It was removed by @bilelmoussaoui, but I'll add it back. Current look |
Co-authored-by: Bilal Elmoussaoui <belmouss@redhat.com>
Co-authored-by: Bilal Elmoussaoui <belmouss@redhat.com>
bb8e75c
to
d71f36b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@Hofer-Julian Thank you for merging it! |
Changes
style.css
toresources.gresource.xml
and callload_css()
function inconnect_startup
handler.listings/todo/3/main.rs
file to be able to show them in the chapter:Issues