Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest gir/gir-files #1407

Merged
merged 17 commits into from
Jul 6, 2023
Merged

Update to latest gir/gir-files #1407

merged 17 commits into from
Jul 6, 2023

Conversation

bilelmoussaoui
Copy link
Member

@bilelmoussaoui bilelmoussaoui commented Jun 28, 2023 •
edited
Loading

TODO:

  • Add missing since configs for new enum members
  • Figure out the GdkGLTextureBuilder API See Bind GLTextureBuilder::build #1412
  • Seal manual traits
  • Figure out why sealing DialogExtManual / BuilderScopeImplExt causes a build error

@bilelmoussaoui bilelmoussaoui mentioned this pull request Jul 5, 2023
Closed
@bilelmoussaoui bilelmoussaoui changed the title WIP: Update to latest gir/gir-files Update to latest gir/gir-files Jul 5, 2023
@bilelmoussaoui
gtk: Manually implement GtkAlign
179bd72 
Since GTK 4.11.x a GTK_BASELINE_FILL was added pointing to GTK_BASELINE
and somehow gir doesn't know what to do here and just omits the
GTK_BASELINE from being generated.

To avoid that, manually implement that. Ideally, one would fix gir but
it is too much for a niche case that i won't bother doing so now.
@bilelmoussaoui
Seal manual traits
7bfe8a2
sdroege
sdroege reviewed Jul 6, 2023
View reviewed changes
gdk4-wayland/Cargo.toml Outdated Show resolved Hide resolved
sdroege
sdroege reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me otherwise

@bilelmoussaoui bilelmoussaoui merged commit 7e688dc into master Jul 6, 2023
38 checks passed
@bilelmoussaoui bilelmoussaoui deleted the bilelmoussaoui/update-latest branch July 6, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bilelmoussaoui @sdroege