Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly clippy warnings #1551

Merged
merged 17 commits into from
Jan 20, 2024
Merged

Fix nightly clippy warnings #1551

merged 17 commits into from
Jan 20, 2024

Conversation

bilelmoussaoui
Copy link
Member

No description provided.

ocrete
ocrete reviewed Jan 3, 2024
View reviewed changes
gdk4/src/toplevel_size.rs Outdated Show resolved Hide resolved
bilelmoussaoui
bilelmoussaoui commented Jan 18, 2024
View reviewed changes
Copy link
Member Author

@bilelmoussaoui bilelmoussaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more to do

gdk4/src/auto/enums.rs Outdated Show resolved Hide resolved
gdk4/sys/Cargo.toml Show resolved Hide resolved
gsk4/src/auto/renderer.rs Outdated Show resolved Hide resolved
gsk4/sys/Cargo.toml
@@ -42,7 +42,7 @@ name = "gsk4_sys"
[features]
v4_2 = []
v4_4 = ["v4_2"]
v4_6 = ["v4_4"]
v4_6 = ["v4_2"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crazy gir

gtk4/src/auto/enums.rs Show resolved Hide resolved
gtk4/src/auto/enums.rs Show resolved Hide resolved
gtk4/src/auto/print_dialog.rs Outdated Show resolved Hide resolved
gtk4/src/auto/string_list.rs Outdated Show resolved Hide resolved
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/new-year branch 4 times, most recently from e5fb7f7 to 87bec4d Compare January 20, 2024 19:35
@bilelmoussaoui bilelmoussaoui linked an issue Jan 20, 2024 that may be closed by this pull request
Add binding for GtkGraphicsOffload #1553
Closed
@bilelmoussaoui
Adapt to gtk-rs/gir#1530
08bd71b
@bilelmoussaoui
Regenerate with latest gir/gir-files
dec3dd4
@bilelmoussaoui
Add missing since annotations
7dcc043
@bilelmoussaoui
gsk: Drop no longer needed version config
dfa139b
@bilelmoussaoui
Re-export v4_14 feature
6ee74db
@bilelmoussaoui
CI: Enable v4_14 gsk feature
16e980f
@bilelmoussaoui
gdk: Mark region as non-mutable
c7dcdb3
@bilelmoussaoui
gdk-wayland: Drop the xkb feature
48b9c9c 
It fails to build because of meh/rust-xkb#8
We might remove that feature or replace it somehow

The commit could also be reverted once upstream gets a new fixed
release

but for now, this breaks the docs (using --all-features) & CI
@bilelmoussaoui
Silence some of unsafe docs lint errors
5a738af 
Could be added later
@bilelmoussaoui
ci/msvc: Don't build vulkan backend
bdd944a 
Requires pulling new deps
@bilelmoussaoui
CI: Enable vulkan backend for gsk
915280a
@bilelmoussaoui
gsk: Regen despite the stupid gir error
2cd527d 
Gir stupidly marks the v4_6 depending on v4_2 instead of v4_4, don't know why
and too lazy to debug it, so just let it be
@bilelmoussaoui
CI/msvc: Install glib's python deps
9b5918c
@bilelmoussaoui
gdk4-win32: Fix clippy warnings
11cc9c6
@bilelmoussaoui
Copy link
Member Author

There might still be things to improve/fix, but I am going to land this one already

@bilelmoussaoui bilelmoussaoui merged commit 0b37815 into master Jan 20, 2024
31 checks passed
@bilelmoussaoui bilelmoussaoui deleted the bilelmoussaoui/new-year branch January 20, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege left review comments

@ocrete ocrete ocrete left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add binding for GtkGraphicsOffload
3 participants
@bilelmoussaoui @sdroege @ocrete