Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch gitmodule.clone_repo output to {:ok, repo} #96

Open
jronmi opened this issue Nov 16, 2020 · 2 comments
Open

Mismatch gitmodule.clone_repo output to {:ok, repo} #96

jronmi opened this issue Nov 16, 2020 · 2 comments

Comments

@jronmi
Copy link
Collaborator

jronmi commented Nov 16, 2020

The output of GitModule.clone_repo is defined to output {:ok, String.t()} | {:error, String.t()} but its output is applied to {:ok, repo}. If clone_repo outputs an error it shuts down the entire process

@kitplummer
Copy link
Collaborator

kitplummer commented Nov 16, 2020 via email

@jronmi
Copy link
Collaborator Author

jronmi commented Nov 16, 2020

Gitmodule.clone_repo will throw errors such as in #94
I have not found an input to create a reproducible error output, but I have found that the :enoent error is being outputted by other functions such as Git.log! as well.
In trying to view these files I have found empty some which give the following error when trying to read them: Error reading no such file or directory.
furthermore I have noticed that the tmp folder only contains 154 temp directories. I am not sure why only this amount since they should theoretically all be stored here. also the majority of them have the same PID which might be an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants