Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servlet-api dependency should not be transitive #5

Closed
kelseyfrancis opened this issue Nov 14, 2013 · 1 comment
Closed

servlet-api dependency should not be transitive #5

kelseyfrancis opened this issue Nov 14, 2013 · 1 comment
Milestone

Comments

@kelseyfrancis
Copy link
Contributor

No description provided.

kelseyfrancis added a commit to kelseyfrancis/typesafeconfig-extensions that referenced this issue Nov 14, 2013
@chris-martin
Copy link
Contributor

I realize that the Servlet API is the canonical example of a provided dependency ...

[...] when building a web application for the Java Enterprise Edition, you would set the dependency on the Servlet API and related Java EE APIs to scope provided because the web container provides those classes.

https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html

... but in this case, for-webapps could conceivably be used in a web application that doesn't involve the Servlet API. So I think it should actually be an optional dependency.

Now I'm trying to figure out: Is there actually any difference between <scope>provided</scope> and <optional>true</optional>? In both cases, the dependency is not transitive and is available at compile time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants