Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for HTTP HEAD method for akka-http and http4s #1686

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

abrighton
Copy link
Contributor

Also added minimal test cases to show that the "Unknown method" error no longer occurs.

@github-actions github-actions bot added scala-akka-http Pertains to guardrail-scala-akka-http scala-http4s Pertains to guardrail-scala-http4s labels Feb 5, 2023
@blast-hardcheese
Copy link
Member

I don't know why you're getting these test failures, they look unrelated. I'll take a look

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 84.50% // Head: 83.00% // Decreases project coverage by -1.51% ⚠️

Coverage data is based on head (b4ab96b) compared to base (505a066).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1686      +/-   ##
==========================================
- Coverage   84.50%   83.00%   -1.51%     
==========================================
  Files          95       95              
  Lines        5836     5838       +2     
  Branches      574      583       +9     
==========================================
- Hits         4932     4846      -86     
- Misses        904      992      +88     
Impacted Files Coverage Δ
...ators/scala/akkaHttp/AkkaHttpServerGenerator.scala 92.36% <100.00%> (+0.02%) ⬆️
...enerators/scala/http4s/Http4sServerGenerator.scala 96.83% <100.00%> (+0.01%) ⬆️
...dev/guardrail/generators/spi/FrameworkLoader.scala 80.95% <0.00%> (-14.29%) ⬇️
...ore/src/main/scala/dev/guardrail/SwaggerUtil.scala 76.80% <0.00%> (-10.83%) ⬇️
...a/dev/guardrail/generators/LanguageParameter.scala 89.36% <0.00%> (-10.64%) ⬇️
...a/dev/guardrail/generators/ProtocolGenerator.scala 89.76% <0.00%> (-8.92%) ⬇️
...ev/guardrail/generators/scala/ScalaGenerator.scala 84.39% <0.00%> (-6.39%) ⬇️
...ain/scala/dev/guardrail/core/extract/package.scala 93.75% <0.00%> (-6.25%) ⬇️
...ev/guardrail/generators/spi/ModuleLoadResult.scala 71.08% <0.00%> (-4.82%) ⬇️
...la/dev/guardrail/generators/SwaggerGenerator.scala 70.76% <0.00%> (-4.62%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@blast-hardcheese blast-hardcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Thank you!

@blast-hardcheese blast-hardcheese added the enhancement Functionality that has never existed in guardrail label Feb 6, 2023
@blast-hardcheese blast-hardcheese merged commit 241a8c9 into guardrail-dev:master Feb 6, 2023
@blast-hardcheese blast-hardcheese added the minor Bump minor version label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Functionality that has never existed in guardrail minor Bump minor version scala-akka-http Pertains to guardrail-scala-akka-http scala-http4s Pertains to guardrail-scala-http4s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants